Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There is a bug in
HardwareSerial::setPins()
that sets the UART pins internally to the wrong value at the end of the operation, which may lead to errors inHardwareSerial::end()
, not dettaching the right GPIO from UART.This PR also makes sure that sequential
HardwareSerial::setPins()
will always detach previous attached GPIOs.Tests scenarios
Related links
Closes #8607